PMD 5.1.3 Report
2016-03-25 - 07:32:10


Summary

FilesTotalPriority 1Priority 2Priority 3Priority 4Priority 5
85213
2
5
206
0
0

org.crosswire.jsword.book.Defaults

PrioBegin LineMethodDescription
3
97unsetBible Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
136unsetCommentary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
175unsetDictionary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
214unsetDailyDevotional Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
253unsetGreekDefinitions Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
292unsetHebrewDefinitions Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
331unsetGreekParse Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
370unsetHebrewParse Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
400getDefaultBible Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
407getDefaultCommentary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
414getDefaultDictionary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
421getDefaultDailyDevotional Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
428getDefaultGreekDefinitions Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
435getDefaultHebrewDefinitions Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
442getDefaultGreekParse Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
449getDefaultHebrewParse Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
494checkAllPreferable Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
506checkPreferable Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 18

org.crosswire.jsword.book.sword.SwordUtil

PrioBegin LineMethodDescription
3
60readRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
76readNextRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
120writeRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
125writeNextRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
145readUntilRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
161readUntilRAF Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
219encodeLittleEndian32 Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
235decodeLittleEndian16 Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
253encodeLittleEndian16 Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
267findByte Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
282findByte Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 11

org.crosswire.common.xml.HTMLSerializingContentHandler

PrioBegin LineMethodDescription
3
69decorateTagName StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
70decorateTagName StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
84decorateAttributeName StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
85decorateAttributeName StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
99decorateAttributeValue StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
100decorateAttributeValue StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
115decorateCharacters StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
116decorateCharacters StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
131decorateIndent StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
132decorateIndent StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 10

org.crosswire.jsword.book.sword.RawLDBackend

PrioBegin LineMethodDescription
3
145get Avoid empty catch blocks
3
148get Avoid empty catch blocks
3
186getRawTextLength A switch statement does not contain a break
3
219getIndex A switch statement does not contain a break
3
461external2internal StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
567dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
3
570dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
3
599toIMP Avoid appending characters as strings in StringBuffer.append.
3
606toIMP Avoid printStackTrace(); use a logger call instead.
3
609toIMP Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 10

org.crosswire.common.diff.CommonMiddle

PrioBegin LineMethodDescription
3
96toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
97toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
98toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
99toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
100toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
101toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
102toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
103toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 8

org.crosswire.jsword.book.install.sword.AbstractSwordInstaller

PrioBegin LineMethodDescription
3
104getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
105getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
106getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
107getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
108getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
109getInstallerDefinition StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
337reloadBookList Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 7

org.crosswire.jsword.index.lucene.LuceneQueryDecorator

PrioBegin LineMethodDescription
3
43decorateAllWords StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
70decoratePhrase StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
71decoratePhrase StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
86decorateNotWords StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
100decorateRange StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
101decorateRange StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
102decorateRange StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 7

org.crosswire.jsword.passage.Verse

PrioBegin LineMethodDescription
3
236getVerseIdentifier StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
237getVerseIdentifier StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
238getVerseIdentifier StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
239getVerseIdentifier StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
245clone clone() method should be implemented only if implementing Cloneable interface
3
439parseInt Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 6

org.crosswire.common.diff.PatchEntry

PrioBegin LineMethodDescription
3
153toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
154toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
155toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
156toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
379encode A switch statement does not contain a break
Total number of violations for this class: 5

org.crosswire.common.xml.XMLUtil

PrioBegin LineMethodDescription
3
136escape A switch statement does not contain a break
3
276recloseTags Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3
279recloseTags Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3
282recloseTags Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3
310recloseTags Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 5

org.crosswire.jsword.passage.VerseRange

PrioBegin LineMethodDescription
3
260getOsisRef StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
261getOsisRef StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
269getOsisRef StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
270getOsisRef StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
344clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 5

org.crosswire.jsword.book.sword.SwordBookMetaData

PrioBegin LineMethodDescription
3
459normalize Prefer StringBuffer over += for concatenating strings
3
553hasFeature StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
980adjustHistory Prefer StringBuffer over += for concatenating strings
3
992report These nested if statements could be combined
Total number of violations for this class: 4

org.crosswire.jsword.book.sword.ZVerseBackend

PrioBegin LineMethodDescription
3
379dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
3
391dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
3
429dumpCompRaf Avoid printStackTrace(); use a logger call instead.
3
441dumpCompRaf Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 4

org.crosswire.jsword.bridge.BookInstaller

PrioBegin LineMethodDescription
3
288main Avoid printStackTrace(); use a logger call instead.
3
316main Avoid printStackTrace(); use a logger call instead.
3
331main Avoid printStackTrace(); use a logger call instead.
3
333main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 4

org.crosswire.jsword.book.BookData

PrioBegin LineMethodDescription
3
163getBooks Returning 'books' may expose an internal array.
3
416keyIteratorContentByVerse Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
3
458addHeaderAndSetShowDiffsState StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 3

org.crosswire.jsword.book.OSISUtil

PrioBegin LineMethodDescription
3
909isCanonical Avoid unused private methods such as 'isCanonical(Content)'.
3
1129rtfToOsis This call to String.startsWith can be rewritten using String.charAt(0)
3
1218recurseElement Avoid unused private methods such as 'recurseElement(Object,StringBuilder)'.
Total number of violations for this class: 3

org.crosswire.jsword.book.filter.thml.SyncTag

PrioBegin LineMethodDescription
3
80processTag StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
109processTag StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
138processTag StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 3

org.crosswire.jsword.book.install.sword.FTPExample

PrioBegin LineMethodDescription
3
40copyDirectory Prefer StringBuffer over += for concatenating strings
3
128main Avoid printStackTrace(); use a logger call instead.
3
138main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 3

org.crosswire.jsword.book.sword.ConfigEntryTable

PrioBegin LineMethodDescription
3
63ConfigEntryTable Avoid unused constructor parameters such as 'isRootConfig'.
3
76toConf StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
77toConf StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 3

org.crosswire.jsword.examples.APIExamples

PrioBegin LineMethodDescription
3
376installBook Avoid printStackTrace(); use a logger call instead.
3
409installBook Avoid printStackTrace(); use a logger call instead.
3
416installBook Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 3

org.crosswire.jsword.passage.PassageKeyFactory

PrioBegin LineMethodDescription
3
450binarySize Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
484toBinary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
530fromBinary Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 3

org.crosswire.jsword.versification.VersificationToKJVMapper

PrioBegin LineMethodDescription
3
396 Avoid unused private methods such as 'getNonEmptyMappings(Map,T)'.
3
518getQualifiedKeys Avoid unused private methods such as 'getQualifiedKeys(Key)'.
3
532map Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
Total number of violations for this class: 3

org.crosswire.common.diff.DiffCleanup

PrioBegin LineMethodDescription
3
101cleanupSemantic Avoid empty while statements
3
224cleanupEfficiency Avoid empty while statements
Total number of violations for this class: 2

org.crosswire.common.progress.Job

PrioBegin LineMethodDescription
3
362fireStateChanged Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
389updateProgress Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 2

org.crosswire.common.util.IOUtil

PrioBegin LineMethodDescription
3
96unpackZip When doing a String.toLowerCase()/toUpperCase() call, use a Locale
3
118unpackZip These nested if statements could be combined
Total number of violations for this class: 2

org.crosswire.common.util.IniSection

PrioBegin LineMethodDescription
3
302remove These nested if statements could be combined
3
732 StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).
Total number of violations for this class: 2

org.crosswire.common.util.Languages

PrioBegin LineMethodDescription
3
66getName Avoid empty catch blocks
3
210 Avoid protected fields in a final class. Change to private or package access.
Total number of violations for this class: 2

org.crosswire.common.util.NetUtil

PrioBegin LineMethodDescription
3
143makeDirectory These nested if statements could be combined
3
304getAsFile Do not add empty strings
Total number of violations for this class: 2

org.crosswire.common.util.Reporter

PrioBegin LineMethodDescription
3
167fireCapture Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
3
168fireCapture Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
Total number of violations for this class: 2

org.crosswire.jsword.book.basic.AbstractBookMetaData

PrioBegin LineMethodDescription
3
266toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
267toString StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 2

org.crosswire.jsword.book.basic.AbstractPassageBook

PrioBegin LineMethodDescription
1
235getBibleBooks Double checked locking is not thread safe in Java.
2
336 Use of modifier volatile is not recommended.
Total number of violations for this class: 2

org.crosswire.jsword.book.filter.gbf.GBFFilter

PrioBegin LineMethodDescription
3
67clone clone() method should be implemented only if implementing Cloneable interface
3
146parseTags Use opposite operator instead of the logic complement operator.
Total number of violations for this class: 2

org.crosswire.jsword.book.filter.osis.OSISFilter

PrioBegin LineMethodDescription
3
90toOSIS Prefer StringBuffer over += for concatenating strings
3
147clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 2

org.crosswire.jsword.book.study.StrongsNumber

PrioBegin LineMethodDescription
3
90getStrongsNumber StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
3
102getFullStrongsNumber StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 2

org.crosswire.jsword.book.sword.ZLDBackend

PrioBegin LineMethodDescription
3
190dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
3
193dumpIdxRaf Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.OpenFileStateManager

PrioBegin LineMethodDescription
2
275 Use of modifier volatile is not recommended.
2
277 Use of modifier volatile is not recommended.
Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZLDBackendState

PrioBegin LineMethodDescription
3
143getLastUncompressed Returning 'lastUncompressed' may expose an internal array.
3
156setLastUncompressed The user-supplied array 'lastUncompressed' is stored directly.
Total number of violations for this class: 2

org.crosswire.jsword.book.sword.state.ZVerseBackendState

PrioBegin LineMethodDescription
3
170getLastUncompressed Returning 'lastUncompressed' may expose an internal array.
3
193setLastUncompressed The user-supplied array 'lastUncompressed' is stored directly.
Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookIndexer

PrioBegin LineMethodDescription
3
185main Avoid printStackTrace(); use a logger call instead.
3
192main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 2

org.crosswire.jsword.bridge.BookLookup

PrioBegin LineMethodDescription
3
98main Avoid printStackTrace(); use a logger call instead.
3
101main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 2

org.crosswire.jsword.index.lucene.IndexMetadata

PrioBegin LineMethodDescription
3
104getLatestIndexVersionStr Consider simply returning the value vs storing it in local variable 'value'
3
153generateInstalledBooksIndexVersionReport Avoid appending characters as strings in StringBuffer.append.
Total number of violations for this class: 2

org.crosswire.jsword.passage.AbstractKeyList

PrioBegin LineMethodDescription
3
222clone clone() method should be implemented only if implementing Cloneable interface
3
261 StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).
Total number of violations for this class: 2

org.crosswire.jsword.passage.TreeKey

PrioBegin LineMethodDescription
3
155equals Ensure you override both equals() and hashCode()
3
189clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 2

org.crosswire.jsword.versification.VersificationsMapper

PrioBegin LineMethodDescription
1
76instance Double checked locking is not thread safe in Java.
2
253 Use of modifier volatile is not recommended.
Total number of violations for this class: 2

gnu.gpl.GPLMsg

PrioBegin LineMethodDescription
3
30 All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
Total number of violations for this class: 1

gnu.lgpl.LGPLMsg

PrioBegin LineMethodDescription
3
30 All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
Total number of violations for this class: 1

org.crosswire.common.progress.JobManager

PrioBegin LineMethodDescription
3
144fireWorkProgressed Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 1

org.crosswire.common.util.CWClassLoader

PrioBegin LineMethodDescription
3
170adjustPackageSearch Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 1

org.crosswire.common.util.ClassUtil

PrioBegin LineMethodDescription
3
108findClasspathEntry StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 1

org.crosswire.common.util.Ini

PrioBegin LineMethodDescription
3
249remove These nested if statements could be combined
Total number of violations for this class: 1

org.crosswire.common.xml.SerializingContentHandler

PrioBegin LineMethodDescription
3
175 StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).
Total number of violations for this class: 1

org.crosswire.common.xml.TransformingSAXEventProvider

PrioBegin LineMethodDescription
3
83getTemplateInfo These nested if statements could be combined
Total number of violations for this class: 1

org.crosswire.jsword.JSMsg

PrioBegin LineMethodDescription
3
30 All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
Total number of violations for this class: 1

org.crosswire.jsword.JSOtherMsg

PrioBegin LineMethodDescription
3
30 All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
Total number of violations for this class: 1

org.crosswire.jsword.book.Bookmark

PrioBegin LineMethodDescription
3
97clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.DataPolice

PrioBegin LineMethodDescription
3
66report StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable.
Total number of violations for this class: 1

org.crosswire.jsword.book.basic.DefaultBookmark

PrioBegin LineMethodDescription
3
98clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.filter.SourceFilterFactory

PrioBegin LineMethodDescription
2
92 Use of modifier volatile is not recommended.
Total number of violations for this class: 1

org.crosswire.jsword.book.filter.gbf.GBFTagBuilders

PrioBegin LineMethodDescription
3
78getTag This call to String.startsWith can be rewritten using String.charAt(0)
Total number of violations for this class: 1

org.crosswire.jsword.book.filter.plaintext.PlainTextFilter

PrioBegin LineMethodDescription
3
64clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.filter.thml.THMLFilter

PrioBegin LineMethodDescription
3
92clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.install.InstallManager

PrioBegin LineMethodDescription
3
303fireInstallersChanged Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsBookDriver

PrioBegin LineMethodDescription
3
61getBooks Returning 'books' may expose an internal array.
Total number of violations for this class: 1

org.crosswire.jsword.book.readings.ReadingsKey

PrioBegin LineMethodDescription
3
103clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.AbstractKeyBackend

PrioBegin LineMethodDescription
3
151clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawBackend

PrioBegin LineMethodDescription
3
250getIndex A switch statement does not contain a break
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.RawFileBackend

PrioBegin LineMethodDescription
3
164createDataTextFile Prefer StringBuffer over += for concatenating strings
Total number of violations for this class: 1

org.crosswire.jsword.book.sword.SwordBook

PrioBegin LineMethodDescription
3
187addOSIS Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty()
Total number of violations for this class: 1

org.crosswire.jsword.bridge.BookExporter

PrioBegin LineMethodDescription
3
95main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 1

org.crosswire.jsword.bridge.ConfParser

PrioBegin LineMethodDescription
3
76main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 1

org.crosswire.jsword.bridge.DwrBridge

PrioBegin LineMethodDescription
3
131getOSISString Avoid empty catch blocks
Total number of violations for this class: 1

org.crosswire.jsword.examples.BibleToOsis

PrioBegin LineMethodDescription
3
69main Avoid printStackTrace(); use a logger call instead.
Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.InstalledIndex

PrioBegin LineMethodDescription
3
109storeInstalledIndexMetadata Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access.
Total number of violations for this class: 1

org.crosswire.jsword.index.lucene.LuceneIndex

PrioBegin LineMethodDescription
3
216LuceneIndex These nested if statements could be combined
Total number of violations for this class: 1

org.crosswire.jsword.passage.AbstractPassage

PrioBegin LineMethodDescription
3
136clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.BitwisePassage

PrioBegin LineMethodDescription
3
113clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.DefaultLeafKeyList

PrioBegin LineMethodDescription
3
244clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.DistinctPassage

PrioBegin LineMethodDescription
3
99clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.Key

PrioBegin LineMethodDescription
3
204clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.PassageTally

PrioBegin LineMethodDescription
3
185clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.RangedPassage

PrioBegin LineMethodDescription
3
102clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyKeyList

PrioBegin LineMethodDescription
3
215clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.ReadOnlyPassage

PrioBegin LineMethodDescription
3
387clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.passage.SynchronizedPassage

PrioBegin LineMethodDescription
3
336clone clone() method should be implemented only if implementing Cloneable interface
Total number of violations for this class: 1

org.crosswire.jsword.versification.BibleNames

PrioBegin LineMethodDescription
3
494 Possible unsafe assignment to a non-final static field in a constructor.
Total number of violations for this class: 1

Generated by PMD 5.1.3 on 2016-03-25 - 07:32:10.